Merged
Conversation
Contributor
Author
|
I guess #1491 will need to be merged first, for the vulnerability check to be happy. I cannot access the 5 Issues found by "Licence Compliance" - Is there something I need to do / fix? |
Member
|
@maboehm can you please rebase |
Contributor
Author
|
I rebased. Since you changed the go version in go.mod to 1.24 the matrix tests don't make sense. So the only change left in this PR is changing the version of |
cpanato
previously approved these changes
Apr 28, 2025
cpanato
reviewed
May 16, 2025
.github/workflows/release.yml
Outdated
| - uses: ko-build/setup-ko@3aebd0597dc1e9d1a26bcfdb7cbeb19c131d3037 # v0.7 | ||
| with: | ||
| version: v0.16.0 # DO NOT REMOVE THIS OR IT WILL CREATE A CYCLE. | ||
| version: v0.17.1 # DO NOT REMOVE THIS OR IT WILL CREATE A CYCLE. |
cpanato
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that using the ko docker image it is currently not possible to build projects that specify the latest go version in their
go.mod:I guess all that would be needed is to just create a new release, that rebuilds the images, since the ko image always uses the latest golang image as its base.
To prepare that it probably makes sense to run the tests against these versions, and then a new release could be published.