add documentation for installing custom root ca certificates#1428
Merged
imjasonh merged 2 commits intoko-build:mainfrom Oct 30, 2024
Merged
add documentation for installing custom root ca certificates#1428imjasonh merged 2 commits intoko-build:mainfrom
imjasonh merged 2 commits intoko-build:mainfrom
Conversation
kosamson
commented
Oct 18, 2024
cpanato
reviewed
Oct 18, 2024
Member
cpanato
left a comment
There was a problem hiding this comment.
also can use: https://github.com/chainguard-dev/incert after you build your image with ko
Contributor
Author
This is really useful, I've never heard about this before. Let me add a section on using this in the new documentation page. This makes building a CI workflow to add the certificates automatically seem really easy. |
Contributor
Author
|
added a section on using |
adds a documentation page under the advanced section outlining how to install custom root certificates into a container built using ko
dc2aa83 to
a57003d
Compare
Contributor
Author
|
rebased my branch to main. i haven't done a github PR in a while so not sure if I messed up the review workflow. if I need to change something pls let me know and I'll fix it. |
|
Hey I'm Revus F |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a documentation page under the "Advanced" section outlining how to install custom root certificates into a container built using
ko.Discussed initially in #1424 and suggested by @jeffmendoza