Update recorder to lazy create file.#1379
Merged
imjasonh merged 2 commits intoko-build:mainfrom Oct 16, 2024
Merged
Conversation
imjasonh
approved these changes
Oct 16, 2024
Currently the resolver command creates the image-refs file on initilization. This causes git to be dirty during builds. This change moves the file creation to be in the recorder itself and on the first time the Publish() method is called. This happens after the build so git is clean. This will mean that any errors on file creation will be reported after the build rather than before. Signed-off-by: Jeff Mendoza <jlm@jlm.name>
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
73b6264 to
31bf4b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the resolver command creates the image-refs file on initialization. This causes git to be dirty during builds. This change moves the file creation to be in the recorder itself and on the first time the Publish() method is called. This happens after the build so git is clean. This will mean that any errors on file creation will be reported after the build rather than before.
Fixes #1378