Merged
Conversation
imjasonh
requested changes
May 14, 2024
e86f28f to
f3b2bfc
Compare
imjasonh
previously approved these changes
May 14, 2024
imjasonh
reviewed
May 14, 2024
Supports configuring global `env` variables that will be applied to all builds. Modifies the `builder` function to accept a `buildContext` structure. This will simplify similar modifications in the future. Fixes ko-build#1305 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
imjasonh
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports configuring global
envvariables that will be applied to all builds.Modifies the
builderfunction to accept abuildContextstructure. This will simplify similar modifications in the future.Fixes #1305