Skip to content

feat: add image user option#1266

Merged
imjasonh merged 1 commit intoko-build:mainfrom
maxbrunet:feat/image-user
Oct 24, 2024
Merged

feat: add image user option#1266
imjasonh merged 1 commit intoko-build:mainfrom
maxbrunet:feat/image-user

Conversation

@maxbrunet
Copy link
Contributor

@maxbrunet maxbrunet commented Mar 23, 2024

Hello! 👋

When using a base image that does not set a user (e.g. busybox), it is desirable to set a non-root user for the built image. At the moment, this requires building a custom image built with another tool to set this value. Since it is a simple config field, it seems reasonable to have an option for it

@rsrchboy
Copy link
Contributor

rsrchboy commented Apr 15, 2024

This would be incredibly useful for a project I'm working on.

@github-actions
Copy link

github-actions bot commented Jul 15, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@maxbrunet
Copy link
Contributor Author

maxbrunet commented Jul 16, 2024

Any chance to get some feedback on this PR? 🙏

@rsrchboy
Copy link
Contributor

rsrchboy commented Oct 2, 2024

I can't do an official review, but going off of CONTRIBUTING (and common sense) things LGTM. Tests are included and pass; --image-user behaves as expected.

CI appears to be complaining about license issues, but apparently the "details" link isn't public, so I don't know what's going on there. Given that this PR does not introduce any library changes, I'm inclined to think that these are preexisting issues.

@imjasonh
Copy link
Member

imjasonh commented Oct 16, 2024

This change looks good to me! Can you rebase so that CI runs and I can approve and merge? 👍

@imjasonh imjasonh enabled auto-merge (rebase) October 16, 2024 17:14
@maxbrunet
feat: add image user option
f52f41f 
Signed-off-by: Maxime Brunet <max@brnt.mx>
auto-merge was automatically disabled October 18, 2024 00:56

Head branch was pushed to by a user without write access

@maxbrunet
Copy link
Contributor Author

maxbrunet commented Oct 18, 2024

This change looks good to me! Can you rebase so that CI runs and I can approve and merge? 👍

Done! ❤️

@HeavyWombat
Copy link
Contributor

HeavyWombat commented Oct 18, 2024

Looking forward to testing this out.

@imjasonh imjasonh merged commit ac22328 into ko-build:main Oct 24, 2024
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imjasonh imjasonh imjasonh approved these changes

@cpanato cpanato cpanato approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maxbrunet @rsrchboy @imjasonh @HeavyWombat @cpanato