chore: remove refs to deprecated io/ioutil#1092
Merged
imjasonh merged 2 commits intoko-build:mainfrom Aug 23, 2023
testwill:ioutil
Merged
chore: remove refs to deprecated io/ioutil#1092imjasonh merged 2 commits intoko-build:mainfrom testwill:ioutil
imjasonh merged 2 commits intoko-build:mainfrom
testwill:ioutil
Conversation
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
cpanato
previously requested changes
Jul 7, 2023
Member
cpanato
left a comment
There was a problem hiding this comment.
thanks for the PR
please check the error
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
Member
|
Thanks for this contribution! It looks good, I'm not sure why CI is stuck. I'll try closing/reopening, but if that doesn't work maybe rebase? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1092 +/- ##
==========================================
- Coverage 52.82% 49.19% -3.64%
==========================================
Files 43 44 +1
Lines 3360 3653 +293
==========================================
+ Hits 1775 1797 +22
- Misses 1359 1624 +265
- Partials 226 232 +6
|
imjasonh
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.