Merged
Conversation
Create a TrustedTypes policy ('knockout') with createHTML and createScript
to allow Knockout to work under CSP require-trusted-types-for enforcement.
Use eval instead of new Function for binding expressions since Chrome
doesn't accept TrustedScript in the Function constructor.
Add e2e tests that verify both production and debug builds under
Trusted Types CSP enforcement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds Trusted Types support to Knockout.
All the changes are behind
typeof trustedTypes !== 'undefined', so this change should only affect Chromium users (where Trusted Types is supported). Unless developers who uses Knockout wants to enforce Trusted Types, this change won't affect anyone.Note that this only prevents DOM-based XSS, so stored and reflected XSS are still possible.
Fixes #2579.