Skip to content

[release-1.9] trigger to build release with go1.19.6 #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Feb 27, 2023
Merged

[release-1.9] trigger to build release with go1.19.6 #459

knative-prow merged 1 commit into from
Feb 27, 2023

Conversation

@dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Feb 27, 2023

@dprotaso dprotaso closed this Feb 27, 2023
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2023
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 27, 2023
@dprotaso dprotaso reopened this Feb 27, 2023
@dprotaso dprotaso changed the base branch from main to release-1.9 February 27, 2023 19:04
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2023
@dprotaso dprotaso mentioned this pull request Feb 27, 2023
Closed
14 tasks
@dprotaso dprotaso closed this Feb 27, 2023
@dprotaso dprotaso reopened this Feb 27, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #459 (51ca126) into release-1.9 (05203a1) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.9     #459   +/-   ##
============================================
  Coverage        72.76%   72.76%           
============================================
  Files                9        9           
  Lines              683      683           
============================================
  Hits               497      497           
  Misses             157      157           
  Partials            29       29

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

psschwei
psschwei reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@dprotaso dprotaso closed this Feb 27, 2023
@dprotaso dprotaso reopened this Feb 27, 2023
@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 27, 2023

/override build-tests_net-gateway-api_main
/override integration-tests-istio_net-gateway-api_main
/override unit-tests_net-gateway-api_main

@knative-prow
Copy link

knative-prow bot commented Feb 27, 2023

@dprotaso: Overrode contexts on behalf of dprotaso: build-tests_net-gateway-api_main, integration-tests-istio_net-gateway-api_main, unit-tests_net-gateway-api_main

Details

In response to this:

/override build-tests_net-gateway-api_main
/override integration-tests-istio_net-gateway-api_main
/override unit-tests_net-gateway-api_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 27, 2023

/override integration-tests-istio_net-gateway-api_release-1.9

@knative-prow
Copy link

knative-prow bot commented Feb 27, 2023

@dprotaso: Overrode contexts on behalf of dprotaso: integration-tests-istio_net-gateway-api_release-1.9

Details

In response to this:

/override integration-tests-istio_net-gateway-api_release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit c0eebd5 into knative-extensions:release-1.9 Feb 27, 2023
@dprotaso dprotaso deleted the bump-release-1.9 branch February 27, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@psschwei psschwei psschwei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@psschwei psschwei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprotaso @psschwei @knative-prow-robot