Skip to content
This repository was archived by the owner on Apr 30, 2024. It is now read-only.

Conversation

@dprotaso
Copy link
Contributor

@knative-prow
Copy link

knative-prow bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #501 (d838dd3) into release-1.8 (a59e6cb) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.8     #501   +/-   ##
============================================
  Coverage        79.16%   79.16%           
============================================
  Files                5        5           
  Lines              288      288           
============================================
  Hits               228      228           
  Misses              49       49           
  Partials            11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@knative-prow knative-prow bot merged commit c093d94 into knative-extensions:release-1.8 Feb 27, 2023
@dprotaso dprotaso deleted the bump-release-1.8 branch February 27, 2023 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants