Initial OpenTelemetry Dashboards #27
Conversation
|
/assign @upodroid I know you seeded the initial dashboards in this repo - if you have any feedback or follow up work let me know |
|
Note this doesn't have 'eventing' - but should be easy to introduce given the 'dashboard as code' setup we now have |
|
Is there any testing for either the existing or new setup? Something as simple as "generate and load config into Prometheus" without running on k8s would be a reasonable first step. |
|
We have some test scripts in the repo here Let me make sure they're still working.
|
|
Ok - made changes and the test scripts work. Since our latest releases don't have the right OTel fixes I've added an option to install the latest nightly $ export NIGHTLY_BUILD=1
$ ./test/setup-cluster.shSome screenshots |
|
I added a basic eventing dashboard (metrics for eventing controller and webhook) |
|
@dprotaso when I run this none of the Knative dashboards seem to show up in the dashboards list here: 
|
|
Are you using |
|
I noticed the eventing dashboard wasn't being installed |
|
The dashboards should be added by a grafana sidecar. It might also take a minute to sync I'm testing with the latest helm charts from various places. You can try |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
evankanderson
left a comment
There was a problem hiding this comment.
I think I understand this now (and thanks to @Cali0707 for double-checking the process).
In the future, we should probably somewhat better document the setup process in either README.md or CONTRIBUTING.md, but this seems like a good start, and I'm happy for it to have been merged.
/lgtm
/approve
There was a problem hiding this comment.
These are .json files because everything else uses jsonnet, right? Otherwise, YAML feels like it might be easier to review / adjust.
There was a problem hiding this comment.
Since JSON can't have comments, can we have a README.md in this directory that points out that these files are generated by ./hack/generate-configmaps.sh?
There was a problem hiding this comment.
These are .json files because everything else uses jsonnet, right?
Yeah jsonnet can't output YAML. We could use two tools (eg. yq) but I didn't want to make this more complicated
There was a problem hiding this comment.
Since JSON can't have comments, can we have a README.md in this directory that points out that these files are generated by ./hack/generate-configmaps.sh?
Let me add a follow up PR
This introduces the initial OpenTelemetry dashboards. Probably important to note that these are 'best-effort'
The dashboards are now defined in 'code' using jsonnet + a grafana jsonnet lib (https://github.com/grafana/grafonnet)
This makes it easy to edit the dashboard and generate the configmaps. Prior it would be manually edited and exported.
/assign @Cali0707 @evankanderson
Note: I'm deleting the older dashboards as they exist in a separate 'opencensus' branch (https://github.com/knative-extensions/monitoring/tree/opencensus). This was necessary not to break older documentation.