Skip to content

Fix Serving Metric Names to match Design Document #16290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Dec 4, 2025
Merged

Fix Serving Metric Names to match Design Document #16290

knative-prow merged 1 commit into from
Dec 4, 2025

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Dec 3, 2025 •
edited
Loading

Part of #16216

The Knative OTel migration design document has the mapping of old metrics and new metrics.

The implementation didn't match the design document.

We now map

  • kn.queueproxy.app.duration -> kn.serving.invocation.duration
  • kn.queueproxy.depth -> kn.serving.queue.depth
Fix metric names to match the original design document `kn.queueproxy.app.duration` becomes `kn.serving.invocation.duration` and `kn.queueproxy.depth` becomes `kn.serving.queue.depth`

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2025
@knative-prow knative-prow bot requested review from dsimansk and skonto December 3, 2025 18:58
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Dec 3, 2025

/cherry-pick release-1.20
/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 3, 2025

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19, release-1.20 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-1.20
/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Dec 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.03%. Comparing base (3908ab8) to head (35a9bdb).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16290      +/-   ##
==========================================
- Coverage   80.06%   80.03%   -0.04%     
==========================================
  Files         215      215              
  Lines       13320    13320              
==========================================
- Hits        10665    10661       -4     
- Misses       2296     2299       +3     
- Partials      359      360       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso dprotaso mentioned this pull request Dec 3, 2025
Closed
@dprotaso
Copy link
Member Author

dprotaso commented Dec 3, 2025

cc @Cali0707

@dprotaso
Copy link
Member Author

dprotaso commented Dec 3, 2025

/assign @Cali0707
cc @linkvt

Cali0707
Cali0707 approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ce76741 into knative:main Dec 4, 2025
93 checks passed
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 4, 2025

@dprotaso: new pull request created: #16292

Details

In response to this:

/cherry-pick release-1.20
/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Dec 4, 2025
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 4, 2025

@dprotaso: new pull request created: #16293

Details

In response to this:

/cherry-pick release-1.20
/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Dec 4, 2025
Merged
@dprotaso dprotaso deleted the fix-metric-names branch December 4, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@skonto skonto Awaiting requested review from skonto

1 more reviewer

@Cali0707 Cali0707 Cali0707 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprotaso @knative-prow-robot @Cali0707