Skip to content

Suppress 'default value insecure' warning when secure-pod-defaults is enabled. #16218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Nov 3, 2025
Merged

Suppress 'default value insecure' warning when secure-pod-defaults is enabled. #16218

knative-prow merged 1 commit into from
Nov 3, 2025

Conversation

@nader-ziada
Copy link
Member

@nader-ziada nader-ziada commented Nov 3, 2025

Proposed Changes

  • As a follow up to PR: Introduce new SecurePodDefaults options #16042 that added new options for secure-pod-defaults, suppress the "Knative may default this to secure in a future release" warning when the feature secure-pod-default is AllowRootBounded or Enabled

@nader-ziada
Suppress 'default value insecure' warning
61be491 
warning is suppressed when the feature secure pod default is enabled.

Signed-off-by: Nader Ziada <nziada@redhat.com>
@knative-prow knative-prow bot requested review from dprotaso and skonto November 3, 2025 19:06
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.05%. Comparing base (7ceeaea) to head (61be491).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16218      +/-   ##
==========================================
+ Coverage   80.03%   80.05%   +0.01%     
==========================================
  Files         214      214              
  Lines       13281    13281              
==========================================
+ Hits        10630    10632       +2     
+ Misses       2292     2291       -1     
+ Partials      359      358       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nader-ziada
Copy link
Member Author

nader-ziada commented Nov 3, 2025

/test upgrade-tests

@dprotaso
Copy link
Member

dprotaso commented Nov 3, 2025

/lgtm
/approve
/cherry-pick release-1.20

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 3, 2025

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.20 in a new PR and assign it to you.

Details

In response to this:

/lgtm
/approve
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@knative-prow knative-prow bot merged commit 7283f2a into knative:main Nov 3, 2025
91 checks passed
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 3, 2025

@dprotaso: new pull request created: #16220

Details

In response to this:

/lgtm
/approve
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@skonto skonto Awaiting requested review from skonto

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nader-ziada @dprotaso @knative-prow-robot