Skip to content

Revert "Add default conditions to create PA to avoid potential race conditions (#16078)" #16118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Oct 7, 2025
Merged

Revert "Add default conditions to create PA to avoid potential race conditions (#16078)" #16118

knative-prow merged 1 commit into from
Oct 7, 2025

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 6, 2025 •
edited
Loading

This reverts commit 561f348/ PR #16078

It looks like the change is flaky

Screenshot 2025-10-06 at 4 09 11 PM

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 6, 2025
@knative-prow knative-prow bot requested review from dsimansk and skonto October 6, 2025 20:08
@knative-prow
Copy link

knative-prow bot commented Oct 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.14%. Comparing base (1c8d21b) to head (3200fd8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16118      +/-   ##
==========================================
+ Coverage   80.01%   80.14%   +0.13%     
==========================================
  Files         214      214              
  Lines       16916    16896      -20     
==========================================
+ Hits        13535    13542       +7     
+ Misses       3021     2997      -24     
+ Partials      360      357       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member Author

dprotaso commented Oct 6, 2025

odd flake
/retest

kapp: Error: create rolebinding/cert-manager-cert-manager-tokenrequest (rbac.authorization.k8s.io/v1) namespace: cert-manager:
  Creating resource rolebinding/cert-manager-cert-manager-tokenrequest (rbac.authorization.k8s.io/v1) namespace: cert-manager:
    API server says: rolebindings.rbac.authorization.k8s.io "cert-manager-cert-manager-tokenrequest" is forbidden: user "prow-job@knative-tests.iam.gserviceaccount.com" (groups=["system:authenticated"]) is attempting to grant RBAC permissions not currently held:
{APIGroups:[""], Resources:["serviceaccounts/token"], ResourceNames:["cert-manager"], Verbs:["create"]} (reason: Forbidden)

@nader-ziada
Copy link
Member

nader-ziada commented Oct 7, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@knative-prow knative-prow bot merged commit 84893c2 into knative:main Oct 7, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@skonto skonto Awaiting requested review from skonto

Assignees

@nader-ziada nader-ziada

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dprotaso @nader-ziada