Skip to content

Change HTTP01 test DNS entry to *.{custom-domain} #13636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Jan 23, 2023
Merged

Change HTTP01 test DNS entry to *.{custom-domain} #13636

knative-prow merged 1 commit into from
Jan 23, 2023

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Jan 23, 2023 •
edited
Loading

Part of knative-extensions/net-certmanager#214 (comment)

Was testing it via #13621

This allows net-certmanager to use commonName of the form k.{custom-domain}

@dprotaso
Change HTTP01 test DNS entry to *.{custom-domain}
ff417c9 
This allows our incoming net-certmanager changes which fixes
issues with long domain names
@knative-prow knative-prow bot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jan 23, 2023
@knative-prow knative-prow bot requested a review from mgencur January 23, 2023 18:29
@knative-prow
Copy link

knative-prow bot commented Jan 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from leetcope January 23, 2023 18:29
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2023
@dprotaso
Copy link
Member Author

dprotaso commented Jan 23, 2023

/assign @KauzClay

@codecov
Copy link

codecov bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

Base: 86.17% // Head: 86.23% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (ff417c9) compared to base (87f5b62).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13636      +/-   ##
==========================================
+ Coverage   86.17%   86.23%   +0.05%     
==========================================
  Files         197      197              
  Lines       14722    14722              
==========================================
+ Hits        12687    12695       +8     
+ Misses       1734     1727       -7     
+ Partials      301      300       -1
Impacted Files Coverage Δ
pkg/autoscaler/scaling/multiscaler.go 88.59% <0.00%> (+1.34%) ⬆️
pkg/reconciler/configuration/configuration.go 84.36% <0.00%> (+1.42%) ⬆️
pkg/autoscaler/statserver/server.go 78.10% <0.00%> (+2.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KauzClay
Copy link
Contributor

KauzClay commented Jan 23, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2023
@dprotaso
Copy link
Member Author

dprotaso commented Jan 23, 2023 •
edited
Loading

This change doesn't affect any of the presubmit tests

/retest

@knative-prow knative-prow bot merged commit 897b61a into knative:main Jan 23, 2023
@evankanderson evankanderson mentioned this pull request Jan 24, 2023
Merged
@dprotaso dprotaso deleted the http01-dns branch February 1, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgencur mgencur Awaiting requested review from mgencur

@leetcope leetcope Awaiting requested review from leetcope

Assignees

@KauzClay KauzClay

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dprotaso @KauzClay