Skip to content

Conversation

@knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #13539

@knative-prow knative-prow bot requested review from nealhu and whaught December 8, 2022 17:41
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2022
@dprotaso
Copy link
Member

dprotaso commented Dec 8, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022
@knative-prow
Copy link

knative-prow bot commented Dec 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 86.53% // Head: 86.51% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (e6ffefd) compared to base (7e6a272).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7   #13543      +/-   ##
===============================================
- Coverage        86.53%   86.51%   -0.03%     
===============================================
  Files              196      196              
  Lines            14515    14515              
===============================================
- Hits             12561    12558       -3     
- Misses            1655     1657       +2     
- Partials           299      300       +1     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 83.67% <0.00%> (-1.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso
Copy link
Member

dprotaso commented Dec 8, 2022

/override istio-latest-no-mesh_serving_release-1.7

@knative-prow
Copy link

knative-prow bot commented Dec 8, 2022

@dprotaso: Overrode contexts on behalf of dprotaso: istio-latest-no-mesh_serving_release-1.7

Details

In response to this:

/override istio-latest-no-mesh_serving_release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 55c141f into knative:release-1.7 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants