Skip to content

Scaling to zero now works when target-burst-capacity is zero. #13501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Nov 24, 2022
Merged

Scaling to zero now works when target-burst-capacity is zero. #13501

knative-prow merged 1 commit into from
Nov 24, 2022

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 23, 2022 •
edited
Loading

Fixes #13487

Proposed Changes

  • The autoscaler sends a probe to detect the activator is in the data
    path. This probe was inadvertently passed to the user container which
    was preventing scale to 0.

Release Note

Scaling to zero now works when target-burst-capacity is zero.

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2022
@dprotaso dprotaso changed the title [WIP] Fix scale down when TBC=0 [WIP] Fix scale to zero when TBC=0 Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Base: 86.44% // Head: 86.44% // No change to project coverage 👍

Coverage data is based on head (912ecdb) compared to base (cd1cd1a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13501   +/-   ##
=======================================
  Coverage   86.44%   86.44%           
=======================================
  Files         196      196           
  Lines       14600    14600           
=======================================
  Hits        12621    12621           
  Misses       1678     1678           
  Partials      301      301
Impacted Files Coverage Δ
pkg/queue/sharedmain/main.go 0.61% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso
Copy link
Member Author

dprotaso commented Nov 23, 2022

/retest

@dprotaso
Ensure probes from the autoscaler are not passed to the user-container
912ecdb 
The autoscaler sends a probe to detect the activator is in the data
path. This probe was inadvertently passed to the user container which
was preventing scale to 0.
@dprotaso dprotaso force-pushed the fix-tcb-zero-scale-down branch from b07f1fb to 912ecdb Compare November 24, 2022 00:54
@knative-prow
Copy link

knative-prow bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso dprotaso changed the title [WIP] Fix scale to zero when TBC=0 Scaling to zero now works when target-burst-capacity is zero. Nov 24, 2022
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2022
@dprotaso
Copy link
Member Author

dprotaso commented Nov 24, 2022

/assign @dprotaso

@dprotaso
Copy link
Member Author

dprotaso commented Nov 24, 2022

whoops
/unassign @dprotaso
/assign @nader-ziada

@knative-prow knative-prow bot assigned nader-ziada and unassigned dprotaso Nov 24, 2022
@nader-ziada
Copy link
Member

nader-ziada commented Nov 24, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@knative-prow knative-prow bot merged commit 05a28e0 into knative:main Nov 24, 2022
@dprotaso dprotaso deleted the fix-tcb-zero-scale-down branch November 24, 2022 15:23
@dprotaso
Copy link
Member Author

dprotaso commented Nov 24, 2022

/cherry-pick release-1.8

@dprotaso
Copy link
Member Author

dprotaso commented Nov 24, 2022

/cherry-pick release-1.7

@dprotaso
Copy link
Member Author

dprotaso commented Nov 24, 2022

/cherry-pick release-1.6

@dprotaso
Copy link
Member Author

dprotaso commented Nov 24, 2022

/cherry-pick release-1.5

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 24, 2022
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 24, 2022

@dprotaso: new pull request created: #13503

Details

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 24, 2022
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 24, 2022

@dprotaso: new pull request created: #13504

Details

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 24, 2022
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 24, 2022

@dprotaso: new pull request created: #13505

Details

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 24, 2022
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 24, 2022

@dprotaso: new pull request created: #13506

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso dprotaso added this to the v1.9.0 milestone Nov 24, 2022
@dprotaso dprotaso mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nader-ziada nader-ziada

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.9.0

Development

Successfully merging this pull request may close these issues.

Old revision does not scale down when TargetBurstCapacity set to 0

3 participants

@dprotaso @nader-ziada @knative-prow-robot