Skip to content

Log context cancellation as debug instead of error #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Oct 7, 2025
Merged

Log context cancellation as debug instead of error #3268

knative-prow merged 1 commit into from
Oct 7, 2025

Conversation

@thiagomedina
Copy link
Member

@thiagomedina thiagomedina commented Oct 6, 2025

Changes

  • Change context cancellation logging from ERROR to DEBUG

/kind enhancement

Fixes knative/serving#13746

Release Note

Docs

@knative-prow knative-prow bot added kind/enhancement size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2025
@knative-prow knative-prow bot requested review from creydr and skonto October 6, 2025 23:39
@codecov
Copy link

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.06%. Comparing base (1e71536) to head (4bc198e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
network/error_handler.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3268   +/-   ##
=======================================
  Coverage   75.05%   75.06%           
=======================================
  Files         187      187           
  Lines       10244    10247    +3     
=======================================
+ Hits         7689     7692    +3     
- Misses       2315     2316    +1     
+ Partials      240      239    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thiagomedina thiagomedina mentioned this pull request Oct 6, 2025
Merged
@dprotaso
Copy link
Member

dprotaso commented Oct 6, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, thiagomedina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@dprotaso
Copy link
Member

dprotaso commented Oct 7, 2025

@thiagomedina we have automation that bumps dependencies daily so this change will get into serving tomorrow

@knative-prow knative-prow bot merged commit e53fcbb into knative:main Oct 7, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@creydr creydr Awaiting requested review from creydr

@skonto skonto Awaiting requested review from skonto

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misleading Error is logged

2 participants

@thiagomedina @dprotaso