Bump OTel dependencies and semconv #3245
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3245 +/- ##
==========================================
+ Coverage 75.04% 75.07% +0.02%
==========================================
Files 187 187
Lines 10250 10249 -1
==========================================
+ Hits 7692 7694 +2
+ Misses 2318 2316 -2
+ Partials 240 239 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/hold for reviews |
| func buildPrometheus(_ context.Context, cfg Config) (sdkmetric.Reader, shutdownFunc, error) { | ||
| r, err := otelprom.New() | ||
| r, err := otelprom.New( | ||
| otelprom.WithTranslationStrategy(otlptranslator.UnderscoreEscapingWithSuffixes), |
There was a problem hiding this comment.
This looks great. Would it be possible to make it configurable in the future? We do want to enable users across the ecosystem to use otel-native names if they so choose.
There was a problem hiding this comment.
We do want to enable users across the ecosystem to use otel-native names if they so choose.
I think for now I'll leave this as the default for prom pull. If we get requests we can add other the strategies. Users can still push OTel metric names
|
@ywwg: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
015e8d9 to
d5d2739
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, dprotaso, ywwg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
The default strategy remains the same
UnderscoreEscapingWithSuffixes- it is just explicit nowFixes: #3224
Note: I don't plan on cherry-picking this back to our 1.19 release branch