Skip to content

Bump min kubernetes to v1.23 #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Oct 5, 2022
Merged

Bump min kubernetes to v1.23 #2595

knative-prow merged 1 commit into from
Oct 5, 2022

Conversation

@psschwei
Copy link
Member

@psschwei psschwei commented Sep 16, 2022

Signed-off-by: Paul S. Schweigert paul@paulschweigert.com

Changes

Fixes #2594

@psschwei
bump min kubernetes to v1.23
3f8641f 
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2022
@psschwei psschwei mentioned this pull request Sep 16, 2022
Merged
@codecov
Copy link

codecov bot commented Sep 16, 2022 •
edited
Loading

Codecov Report

Base: 81.25% // Head: 81.29% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (3f8641f) compared to base (cc6e435).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
+ Coverage   81.25%   81.29%   +0.03%     
==========================================
  Files         162      162              
  Lines        9801     9820      +19     
==========================================
+ Hits         7964     7983      +19     
  Misses       1597     1597              
  Partials      240      240
Impacted Files Coverage Δ
configmap/hash-gen/main.go 62.96% <0.00%> (ø)
metrics/resource_view.go 86.89% <ø> (ø)
network/error_handler.go 0.00% <0.00%> (ø)
version/version.go 100.00% <ø> (ø)
configmap/load.go 79.31% <100.00%> (ø)
websocket/connection.go 93.85% <100.00%> (ø)
...k/resourcesemantics/validation/reconcile_config.go 82.85% <0.00%> (+2.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skonto
Copy link
Contributor

skonto commented Sep 23, 2022 •
edited
Loading

vendor/k8s.io/cli-runtime/pkg/resource/dry_run_verifier.go:78:34: cannot use oapi (variable of type *"github.com/google/gnostic/openapiv2".Document) as type *"github.com/googleapis/gnostic/openapiv2".Document in argument to supportsDryRun

@skonto
Copy link
Contributor

skonto commented Sep 23, 2022

/retest

@nader-ziada nader-ziada mentioned this pull request Sep 27, 2022
Merged
@matzew matzew mentioned this pull request Sep 28, 2022
Merged
5 tasks
@matzew
Copy link
Member

matzew commented Sep 30, 2022

@psschwei @skonto what does prevent us from merging this?

@psschwei
Copy link
Member Author

psschwei commented Sep 30, 2022

@psschwei @skonto what does prevent us from merging this?

Nothing I'm aware of, just needs a review

@psschwei psschwei closed this Oct 5, 2022
@psschwei psschwei reopened this Oct 5, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@nader-ziada
Copy link
Member

nader-ziada commented Oct 5, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
@knative-prow knative-prow bot merged commit bc93b0a into knative:main Oct 5, 2022
@nader-ziada nader-ziada mentioned this pull request Oct 5, 2022
Merged
This was referenced Oct 7, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nader-ziada nader-ziada

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make K8s 1.23 mandatory

4 participants

@psschwei @skonto @matzew @nader-ziada