Skip to content

Conversation

@lkingland
Copy link
Member

Adds json output to the func run command

/kind enhancement

func run now supports json output

@knative-prow knative-prow bot requested review from nainaz and vyasgun June 27, 2025 03:57
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2025
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.65%. Comparing base (c865638) to head (bdba363).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/run.go 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2893      +/-   ##
==========================================
+ Coverage   60.83%   61.65%   +0.81%     
==========================================
  Files         129      129              
  Lines       16215    16241      +26     
==========================================
+ Hits         9865    10013     +148     
+ Misses       5429     5277     -152     
- Partials      921      951      +30     
Flag Coverage Δ
e2e-tests 42.41% <33.33%> (+1.37%) ⬆️
integration-tests 48.10% <90.00%> (+1.80%) ⬆️
unit-tests 48.24% <90.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2025
@lkingland lkingland force-pushed the push-wxqlzmtpmzol branch from d9aa590 to a8fa640 Compare June 30, 2025 01:08
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2025
@lkingland lkingland force-pushed the push-wxqlzmtpmzol branch from a8fa640 to 3db2dde Compare June 30, 2025 01:26
@lkingland lkingland force-pushed the push-wxqlzmtpmzol branch from 3db2dde to bdba363 Compare June 30, 2025 05:07
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025
@knative-prow
Copy link

knative-prow bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 56e1b0f into knative:main Jun 30, 2025
39 of 40 checks passed
@lkingland lkingland deleted the push-wxqlzmtpmzol branch July 1, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants