Skip to content

Fix: build correct func-util binary for give arch #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
May 26, 2025
Merged

Fix: build correct func-util binary for give arch #2843

knative-prow merged 1 commit into from
May 26, 2025

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented May 26, 2025

No description provided.

@matejvasek
Fix: build correct func-util binary for give arch
9545c14 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot requested review from dsimansk and vyasgun May 26, 2025 19:16
@knative-prow
Copy link

knative-prow bot commented May 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2025
@matejvasek matejvasek requested review from gauron99, jrangelramos, lkingland and matzew and removed request for dsimansk and vyasgun May 26, 2025 19:16
@matejvasek matejvasek mentioned this pull request May 26, 2025
Merged
@matejvasek
Copy link
Contributor Author

matejvasek commented May 26, 2025

PTAL @jrangelramos @lkingland

@codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.47%. Comparing base (4c4fd28) to head (9545c14).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2843      +/-   ##
==========================================
+ Coverage   62.68%   63.47%   +0.78%     
==========================================
  Files         127      127              
  Lines       15543    15545       +2     
==========================================
+ Hits         9743     9867     +124     
+ Misses       4890     4738     -152     
- Partials      910      940      +30
Flag Coverage Δ
e2e-tests 43.63% <ø> (+1.46%) ⬆️
integration-tests 49.48% <ø> (+1.84%) ⬆️
unit-tests 49.53% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor Author

matejvasek commented May 26, 2025

/test unit-tests

@matejvasek
Copy link
Contributor Author

matejvasek commented May 26, 2025

I don't know how I could have missed this.

@jrangelramos
Copy link
Contributor

jrangelramos commented May 26, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2025
@knative-prow knative-prow bot merged commit 0ce5759 into knative:main May 26, 2025
35 checks passed
@matejvasek matejvasek mentioned this pull request Dec 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew Awaiting requested review from matzew

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@gauron99 gauron99 Awaiting requested review from gauron99

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@jrangelramos jrangelramos

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matejvasek @jrangelramos