Skip to content

Make ApiServerSource SkipPermissions exit always and restart the pod #8736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Sep 26, 2025
Merged

Make ApiServerSource SkipPermissions exit always and restart the pod #8736

knative-prow merged 1 commit into from
Sep 26, 2025

Conversation

@rh-hemartin
Copy link
Contributor

@rh-hemartin rh-hemartin commented Sep 23, 2025 •
edited
Loading

Fixes #8675

I'm unable to reproduce the error we had for this ("Resource version too old") so I don't know how to test it.

Proposed Changes

  • 🐛 Fix bug where the skip-permissions/fail-fast mode of ApiServerSource was not restarting under some circumstances

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Fix a bug where the SkipPermissions mode of the ApiServerSource was not restarting the adapter pod properly.

Docs

@rh-hemartin
Make ApiServerSource failfast exit always
544e7ce 
Signed-off-by: Hector Martinez <hemartin@redhat.com>
@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 23, 2025

Hi @rh-hemartin. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from Cali0707 and matzew September 23, 2025 05:58
@codecov
Copy link

codecov bot commented Sep 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.21%. Comparing base (ffe3a4b) to head (544e7ce).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/adapter/apiserver/adapter.go 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8736   +/-   ##
=======================================
  Coverage   50.20%   50.21%           
=======================================
  Files         409      409           
  Lines       26659    26662    +3     
=======================================
+ Hits        13385    13389    +4     
- Misses      12431    12432    +1     
+ Partials      843      841    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

matzew
matzew reviewed Sep 24, 2025
View reviewed changes
pkg/adapter/apiserver/adapter.go
cancelWatchers()
// ListAndWatch could exit with `nil` under some circumstances, it shouldn't
// ever stop listening and watching, so we will treat any exit as a reason to restart
err := reflector.ListAndWatchWithContext(watchCtx)
Copy link
Member

@matzew matzew Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this improve your scenario?

CC @creydr

Copy link
Contributor Author

@rh-hemartin rh-hemartin Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our fork we removed these changes, we just kept the Eventing Controller part because we do not want Subject Access Review requests. We just accepted not having the fail fast behaviour.

@creydr
Copy link
Member

creydr commented Sep 24, 2025

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2025
@creydr
Copy link
Member

creydr commented Sep 25, 2025 

ERROR: (gcloud.container.clusters.create) ResponseError: code=500, message=Internal error encountered.

infra issues
/retest

matzew
matzew approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, rh-hemartin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2025
@knative-prow knative-prow bot merged commit bfd6957 into knative:main Sep 26, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ApiServerSource missing activity

3 participants

@rh-hemartin @creydr @matzew