Skip to content

Fix hardcoded knative-eventing namespace #8575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 2 commits into from
Apr 29, 2025
Merged

Fix hardcoded knative-eventing namespace #8575

knative-prow merged 2 commits into from
Apr 29, 2025

Conversation

@matzew
Copy link
Member

@matzew matzew commented Apr 29, 2025

Fixes #8407

Proposed Changes

  • 🧹 remove hard-coded knative-eventing namepsace in controller logic

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

matzew added 2 commits April 29, 2025 15:03
@matzew
💫 Remove hard-coded knative-eventing namespace and replace with syste…
f309240 
…m.Namespace() and touch test to get that properly injected

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
🧹 Remove yet another hard-coded instance of knative-eventing
fe8bb0a 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2025
@matzew matzew mentioned this pull request Apr 29, 2025
Closed
@knative-prow
Copy link

knative-prow bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from Leo6Leo and lionelvillard April 29, 2025 13:05
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.31%. Comparing base (7146629) to head (fe8bb0a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8575   +/-   ##
=======================================
  Coverage   52.31%   52.31%           
=======================================
  Files         397      397           
  Lines       24925    24925           
=======================================
  Hits        13039    13039           
  Misses      11099    11099           
  Partials      787      787

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matzew
Copy link
Member Author

matzew commented Apr 29, 2025

/assign @eloo-abi
/assign @Cali0707
/assign @creydr

Please take a look

@knative-prow
Copy link

knative-prow bot commented Apr 29, 2025

@matzew: GitHub didn't allow me to assign the following users: eloo-abi.

Note that only knative members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @eloo-abi
/assign @Cali0707
/assign @creydr

Please take a look

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@creydr
Copy link
Member

creydr commented Apr 29, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
@matzew
Copy link
Member Author

matzew commented Apr 29, 2025

/test unit-tests

@matzew
Copy link
Member Author

matzew commented Apr 29, 2025

/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 29, 2025

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member Author

matzew commented Apr 29, 2025

/cherry-pick release-1.18

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 29, 2025

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 9120685 into knative:main Apr 29, 2025
36 checks passed
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 29, 2025

@matzew: new pull request created: #8577

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Apr 29, 2025
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 29, 2025

@matzew: new pull request created: #8578

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@creydr creydr

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to deploy eventing in different namespace because of hardcoded namespace

4 participants

@matzew @creydr @knative-prow-robot @Cali0707