Skip to content

Scheduler: Resync reserved periodically to keep state consistent #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Feb 11, 2025
Merged

Scheduler: Resync reserved periodically to keep state consistent #8451

knative-prow merged 1 commit into from
Feb 11, 2025

Conversation

@pierDipi
Copy link
Member

@pierDipi pierDipi commented Feb 11, 2025

Add resyncReserved removes deleted vPods from reserved to keep the state consistent when leadership changes (Promote / Demote).

initReserved is not enough since the vPod lister can be stale.

Fixes #

Proposed Changes

  • Resync reserved periodically to keep state consistent

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 11, 2025
@knative-prow knative-prow bot requested review from aliok and creydr February 11, 2025 13:02
@pierDipi
Copy link
Member Author

pierDipi commented Feb 11, 2025

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 11, 2025

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

pierDipi commented Feb 11, 2025

/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 11, 2025

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Scheduler: Resync reserved periodically to keep state consistent
4c53339 
Add resyncReserved removes deleted vPods from reserved to keep the
state consistent when leadership changes (Promote / Demote).

`initReserved` is not enough since the vPod lister can be stale.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the scheduler-resync-reserved branch from fb242cd to 4c53339 Compare February 11, 2025 13:19
@codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 63.91%. Comparing base (4a6e7d2) to head (4c53339).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/statefulset/scheduler.go 62.50% 12 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8451      +/-   ##
==========================================
- Coverage   64.10%   63.91%   -0.19%     
==========================================
  Files         388      391       +3     
  Lines       23363    23543     +180     
==========================================
+ Hits        14976    15048      +72     
- Misses       7591     7691     +100     
- Partials      796      804       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a228d2b into knative:main Feb 11, 2025
34 of 36 checks passed
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 11, 2025

@pierDipi: new pull request created: #8452

Details

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Feb 11, 2025
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 11, 2025

@pierDipi: new pull request created: #8453

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Feb 11, 2025
Merged
@pierDipi
Copy link
Member Author

pierDipi commented Feb 11, 2025

/cherry-pick release-1.15

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 11, 2025

@pierDipi: new pull request created: #8454

Details

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@creydr creydr Awaiting requested review from creydr

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierDipi @knative-prow-robot @matzew