Skip to content

Revert "Refactor waiting loop to use resourceVersion #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow-robot merged 2 commits into from
May 18, 2021
Merged

Revert "Refactor waiting loop to use resourceVersion #1321

knative-prow-robot merged 2 commits into from
May 18, 2021

Conversation

@dsimansk
Copy link
Contributor

@dsimansk dsimansk commented May 18, 2021 •
edited
Loading

Description

Per subject revert PR#1301

/assign @rhuss

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 18, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 18, 2021
@knative-metrics-robot
Copy link

knative-metrics-robot commented May 18, 2021

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/eventing/v1/client.go 86.0% 85.8% -0.1
pkg/serving/v1/client.go 69.0% 69.3% 0.3
pkg/wait/wait_for_ready.go 81.0% 76.1% -4.9

@codecov
Copy link

codecov bot commented May 18, 2021 •
edited
Loading

Codecov Report

Merging #1321 (14d7cbc) into main (be8f246) will decrease coverage by 0.06%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
- Coverage   73.04%   72.97%   -0.07%     
==========================================
  Files         160      160              
  Lines        8161     8151      -10     
==========================================
- Hits         5961     5948      -13     
- Misses       1473     1476       +3     
  Partials      727      727
Impacted Files Coverage Δ
pkg/wait/poll_watcher.go 55.88% <0.00%> (+0.80%) ⬆️
pkg/serving/v1/client.go 57.60% <47.36%> (+1.32%) ⬆️
pkg/eventing/v1/client.go 79.16% <71.42%> (-0.18%) ⬇️
pkg/wait/wait_for_ready.go 66.34% <80.00%> (-7.34%) ⬇️
pkg/wait/test_wait_helper.go 95.00% <0.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8f246...14d7cbc. Read the comment docs.

@rhuss
Copy link
Contributor

rhuss commented May 18, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@knative-prow-robot knative-prow-robot merged commit fc4bc4f into knative:main May 18, 2021
@dsimansk dsimansk mentioned this pull request May 31, 2021
Merged
@ericmillin ericmillin mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rhuss rhuss

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsimansk @knative-metrics-robot @rhuss @knative-prow-robot