Skip to content

Add knative-release-leads to OWNERS #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
evankanderson wants to merge 2 commits into from
Closed

Add knative-release-leads to OWNERS #1316

evankanderson wants to merge 2 commits into from

Conversation

@evankanderson
Copy link
Member

@evankanderson evankanderson commented May 17, 2021

Enable release leads to merge go mod changes, etc

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 17, 2021
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2021
@dsimansk dsimansk mentioned this pull request May 17, 2021
Merged
maximilien
maximilien approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve
/lgtm

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2021
rhuss
rhuss approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhuss
Copy link
Contributor

rhuss commented May 17, 2021

/retest

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 17, 2021 •
edited
Loading

@evankanderson: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-client-integration-tests-latest-release 20f082a link /test pull-knative-client-integration-tests-latest-release
pull-knative-client-go-coverage 20f082a link /test pull-knative-client-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 17, 2021

New changes are detected. LGTM label has been removed.

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@rhuss
Copy link
Contributor

rhuss commented May 17, 2021

this PR looks obsolete.

@rhuss rhuss closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@maximilien maximilien maximilien approved these changes

@rhuss rhuss rhuss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maximilien maximilien

@rhuss rhuss

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evankanderson @knative-prow-robot @rhuss @maximilien