Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase by replacing all occurrences of interface{} with the any type alias, which was introduced in Go 1.18 as a cleaner, more readable alternative. The changes are purely syntactic and maintain the same runtime behavior.
Key changes:
- Replace
interface{}withanythroughout the entire codebase - Simplify duplicate logic in
maps/maps.goby introducing a generic helper function - Remove extraneous blank line at end of
parsers/huml/huml.go - Fix formatting/whitespace in several files
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| koanf.go | Updated core type definitions and method signatures from interface{} to any |
| interfaces.go | Updated Provider and Parser interface signatures |
| options.go | Updated merge function signature |
| getters.go | Updated type assertions from interface{} to any |
| maps/maps.go | Replaced interface{} with any and refactored duplicate functions using generics |
| parsers/*.go | Updated parser Unmarshal/Marshal signatures across all parsers |
| providers/*.go | Updated provider Read/Watch method signatures across all providers |
| tests/*.go | Updated test fixtures and type declarations |
| examples/*.go | Updated callback signatures in example code |
| README.md | Updated documentation references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Looks good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interface{}toanywherever possible.sliceToLookupMap()helper function with generics to remove redundant code.