fix: update file watch to trigger callback after symbolic link changes#326
fix: update file watch to trigger callback after symbolic link changes#326knadh merged 2 commits intoknadh:masterfrom
Conversation
|
Sorry, I didn't want to stack too many commits so I closed the old PR and started from scratch. Apologies for not originally seeing the watch tests. I have added an additional watch test to mimic what kubernetes does and validated that the test is successful on my branch and failed without my changes (I did have to add a |
|
@knadh not urgent, but would appreciate a review when you have a chance. Thanks. |
|
Released as |
You're welcome, and thanks for the great library. |
@knadh , perhaps I misunderstood, the changes are now on |
|
Sorry, it's v1.1.2 - https://github.com/knadh/koanf/releases/tag/providers%2Ffile%2Fv1.1.2 |
This fixes issue 323. The changes are based mostly on similar code found in the viper codebase.