Skip to content

install istioctl in tmp dir when running E2E tests#974

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
YaoZengzeng:ordinary-user
Oct 22, 2024
Merged

install istioctl in tmp dir when running E2E tests#974
kmesh-bot merged 2 commits intokmesh-net:mainfrom
YaoZengzeng:ordinary-user

Conversation

@YaoZengzeng
Copy link
Copy Markdown
Member

@YaoZengzeng YaoZengzeng commented Oct 22, 2024

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes part of #930

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@YaoZengzeng
enable ordinary users to run E2E tests
5a9d7ef 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Oct 22, 2024
@YaoZengzeng
remove tmp dir
d4f1a84 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot added size/S and removed size/XS labels Oct 22, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.16%. Comparing base (d119669) to head (d4f1a84).
Report is 19 commits behind head on main.

see 74 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588aa98...d4f1a84. Read the comment docs.

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

LiZhenCheng9527 commented Oct 22, 2024

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Oct 22, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit af3a242 into kmesh-net:main Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@lec-bit lec-bit Awaiting requested review from lec-bit

Assignees

@LiZhenCheng9527 LiZhenCheng9527

Labels

approved kind/enhancement New feature or request lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YaoZengzeng @LiZhenCheng9527 @kmesh-bot @hzxuzhonghu