Skip to content

if sourceworkload is nil, not print metrics#960

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
LiZhenCheng9527:metric-nil-workload
Oct 15, 2024
Merged

if sourceworkload is nil, not print metrics#960
kmesh-bot merged 2 commits intokmesh-net:mainfrom
LiZhenCheng9527:metric-nil-workload

Conversation

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

@LiZhenCheng9527 LiZhenCheng9527 commented Oct 15, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@LiZhenCheng9527
if sourceworkload is nil, not print metric
39bc1b3 
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@LiZhenCheng9527
modifty unit test
1f2940b 
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.45%. Comparing base (739fde5) to head (1f2940b).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/telemetry/metric.go 25.00% 5 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/controller/telemetry/metric.go 55.66% <25.00%> (-0.71%) ⬇️

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85ca41...1f2940b. Read the comment docs.

hzxuzhonghu
hzxuzhonghu approved these changes Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Oct 15, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit ff75cab into kmesh-net:main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kwb0523 kwb0523 Awaiting requested review from kwb0523

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LiZhenCheng9527 @kmesh-bot @hzxuzhonghu