adjust log level for userspace authz#959
Conversation
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
| @@ -179,7 +180,7 @@ func (r *Rbac) doRbac(conn *rbacConnection) bool { | |||
| dstWorkload := r.workloadCache.GetWorkloadByAddr(networkAddress) | |||
| // If no workload found, deny | |||
| if dstWorkload == nil { | |||
There was a problem hiding this comment.
@LiZhenCheng9527 I thought about this again, we cannot deny if src workload is not found. And also cannot simply allow if src not found,
There was a problem hiding this comment.
So we need to discuss different scenarios of source workload not found.
But how should we distinguish between these scenarios?
There was a problem hiding this comment.
not needed from here, auth should not care whether src workload exist or not if the auth policy is based on ip or port
#961 is the way to ignore kubelet probe traffic
Codecov ReportAttention: Patch coverage is
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #955
Special notes for your reviewer:
Does this PR introduce a user-facing change?: