Skip to content

Ignore key not exist error when delete bpf map#957

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
hzxuzhonghu:ignore-key-not-exist
Oct 15, 2024
Merged

Ignore key not exist error when delete bpf map#957
kmesh-bot merged 2 commits intokmesh-net:mainfrom
hzxuzhonghu:ignore-key-not-exist

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu commented Oct 15, 2024

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fix #954

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hzxuzhonghu
Ignore not exist error when delete
a91d6c4 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
Update
969468b 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Oct 15, 2024
@kmesh-bot kmesh-bot requested review from kwb0523 and nlgwcy October 15, 2024 02:44
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.32%. Comparing base (241e679) to head (969468b).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/workload/bpfcache/auth_policy.go 0.00% 4 Missing ⚠️
pkg/controller/workload/bpfcache/endpoint.go 50.00% 1 Missing and 1 partial ⚠️
pkg/controller/workload/bpfcache/frontend.go 60.00% 1 Missing and 1 partial ⚠️
pkg/controller/workload/bpfcache/service.go 50.00% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/controller/workload/bpfcache/backend.go 100.00% <100.00%> (ø)
pkg/controller/workload/workload_processor.go 61.08% <ø> (-0.68%) ⬇️
pkg/controller/workload/bpfcache/endpoint.go 83.75% <50.00%> (-1.97%) ⬇️
pkg/controller/workload/bpfcache/frontend.go 93.54% <60.00%> (-6.46%) ⬇️
pkg/controller/workload/bpfcache/service.go 88.23% <50.00%> (-11.77%) ⬇️
pkg/controller/workload/bpfcache/auth_policy.go 40.00% <0.00%> (-10.00%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588aa98...969468b. Read the comment docs.

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

LiZhenCheng9527 commented Oct 15, 2024

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Oct 15, 2024
@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

LiZhenCheng9527 commented Oct 15, 2024

/approve

@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 0235ded into kmesh-net:main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwb0523 kwb0523 Awaiting requested review from kwb0523

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

Assignees

@LiZhenCheng9527 LiZhenCheng9527

Labels

approved kind/enhancement New feature or request lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unexpected bpf map delete failed error

3 participants

@hzxuzhonghu @LiZhenCheng9527 @kmesh-bot