Skip to content

Fix when bpf loader failed, it should have a chance to dettach bpf pr…#952

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
hzxuzhonghu:fix-bpfloader
Oct 14, 2024
Merged

Fix when bpf loader failed, it should have a chance to dettach bpf pr…#952
kmesh-bot merged 1 commit intokmesh-net:mainfrom
hzxuzhonghu:fix-bpfloader

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu commented Oct 14, 2024

…og and maps

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #951

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hzxuzhonghu
Fix when bpf loader failed, it should have a chance to dettach bpf pr…
241e679 
…og and maps

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.51%. Comparing base (739fde5) to head (241e679).
Report is 18 commits behind head on main.

see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85ca41...241e679. Read the comment docs.

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

LiZhenCheng9527 commented Oct 14, 2024

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Oct 14, 2024
@supercharge-xsy
Copy link
Copy Markdown
Contributor

supercharge-xsy commented Oct 14, 2024

/lgtm
/approve

@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supercharge-xsy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 588aa98 into kmesh-net:main Oct 14, 2024
@hzxuzhonghu
Copy link
Copy Markdown
Member Author

hzxuzhonghu commented Oct 14, 2024

/cherrpick release-0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@supercharge-xsy supercharge-xsy

@LiZhenCheng9527 LiZhenCheng9527

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bpf load failed

4 participants

@hzxuzhonghu @LiZhenCheng9527 @supercharge-xsy @kmesh-bot