Conversation
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
| @@ -1,6 +1,3 @@ | |||
| //go:build integ | |||
| // +build integ | |||
There was a problem hiding this comment.
It is used to seperate test files, we will use it in: https://github.com/kmesh-net/kmesh/blob/main/test/e2e/run_test.sh#L278 .
Although all the files in ./test/e2e/ are used to e2e test.
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
#927
#928 failure have some relationship with istio
Special notes for your reviewer:
Does this PR introduce a user-facing change?: