Skip to content

fix format error of kmeshctl waypoint status --help#942

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
YaoZengzeng:fmt
Oct 12, 2024
Merged

fix format error of kmeshctl waypoint status --help#942
kmesh-bot merged 2 commits intokmesh-net:mainfrom
YaoZengzeng:fmt

Conversation

@YaoZengzeng
Copy link
Copy Markdown
Member

@YaoZengzeng YaoZengzeng commented Oct 11, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Before this fix:

root@dev:~/kmesh# kmeshctl waypoint status --help
Show the status of waypoints for the namespace provided or default namespace if none is provided

Usage:
  kmeshctl waypoint status [flags]

Examples:
  # Show the status of the waypoint in the default namespace
                 kmeshctl waypoint status
                  
                 # Show the status of the waypoint in a specific namespace
                 kmeshctl waypoint status --namespace default

Flags:
  -h, --help   help for status

After this fix:

root@dev:~/kmesh# ./kmeshctl waypoint status --help
Show the status of waypoints for the namespace provided or default namespace if none is provided

Usage:
  kmeshctl waypoint status [flags]

Examples:
  # Show the status of the waypoint in the default namespace
  kmeshctl waypoint status

  # Show the status of the waypoint in a specific namespace
  kmeshctl waypoint status --namespace default

Flags:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@YaoZengzeng
fix format error of kmeshctl waypoint status --help
aa07c16 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Oct 11, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.37%. Comparing base (6ae8865) to head (739fde5).
Report is 14 commits behind head on main.

see 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67058b5...739fde5. Read the comment docs.

LiZhenCheng9527
LiZhenCheng9527 reviewed Oct 11, 2024
View reviewed changes
ctl/waypoint/waypoint.go Outdated
kmeshctl waypoint status

# Show the status of the waypoint in a specific namespace
kmeshctl waypoint status --namespace default`,
Copy link
Copy Markdown
Contributor

@LiZhenCheng9527 LiZhenCheng9527 Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:Perhaps an example should be given that is not a default namespace

@YaoZengzeng
change ns
739fde5 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

LiZhenCheng9527 commented Oct 12, 2024

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Oct 12, 2024
@YaoZengzeng
Copy link
Copy Markdown
Member Author

YaoZengzeng commented Oct 12, 2024

@hzxuzhonghu PTAL

@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit a255c06 into kmesh-net:main Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiZhenCheng9527 LiZhenCheng9527 LiZhenCheng9527 left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

Assignees

@LiZhenCheng9527 LiZhenCheng9527

Labels

approved kind/bug Something isn't working lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YaoZengzeng @LiZhenCheng9527 @kmesh-bot @hzxuzhonghu