Skip to content

upgrade golang to 1.23#929

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
tjons:tjons/795-go-1.23
Oct 8, 2024
Merged

upgrade golang to 1.23#929
kmesh-bot merged 2 commits intokmesh-net:mainfrom
tjons:tjons/795-go-1.23

Conversation

@tjons
Copy link
Copy Markdown

@tjons tjons commented Oct 3, 2024

What type of PR is this?

/kind enhancement

What this PR does / why we need it:
This PR resolves #795 by upgrading the version of go to 1.23.2.

Which issue(s) this PR fixes:
Fixes #795

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade go to 1.23.2

@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Oct 3, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Oct 3, 2024

Welcome @tjons! It looks like this is your first PR to kmesh-net/kmesh 🎉

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (dc26806) to head (9104616).
Report is 8 commits behind head on main.

see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 973cbc6...9104616. Read the comment docs.

hzxuzhonghu
hzxuzhonghu reviewed Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

can you change yhe other github actions gp-version as well

@kmesh-bot kmesh-bot added size/L and removed size/S labels Oct 8, 2024
@tjons tjons force-pushed the tjons/795-go-1.23 branch from c195131 to 9c18630 Compare October 8, 2024 02:33
@tjons tjons force-pushed the tjons/795-go-1.23 branch from a6279e6 to 9c18630 Compare October 8, 2024 02:35
Tyler Schade added 2 commits October 7, 2024 22:35
@tjons
upgrade golang to 1.23
8ed9032 
Signed-off-by: Tyler Schade <tyler.schade@solo.io>
@tjons
update all workflows
9104616 
Signed-off-by: Tyler Schade <tyler.schade@solo.io>
@tjons tjons force-pushed the tjons/795-go-1.23 branch from 9c18630 to 9104616 Compare October 8, 2024 02:35
@tjons
Copy link
Copy Markdown
Author

tjons commented Oct 8, 2024 •
edited
Loading

lgtm

can you change yhe other github actions gp-version as well

@hzxuzhonghu - done! not sure how I missed those :)

this is a very cool project - I'm excited to learn and contribute more

hzxuzhonghu
hzxuzhonghu approved these changes Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Welcome @tjons

@kmesh-bot kmesh-bot added the lgtm label Oct 8, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 3bfcfe2 into kmesh-net:main Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved kind/enhancement New feature or request lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump go to 1.23

3 participants

@tjons @kmesh-bot @hzxuzhonghu