Skip to content

fix slow restart in workload mode#924

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
nlgwcy:bugfix
Sep 30, 2024
Merged

fix slow restart in workload mode#924
kmesh-bot merged 1 commit intokmesh-net:mainfrom
nlgwcy:bugfix

Conversation

@nlgwcy
Copy link
Copy Markdown
Contributor

@nlgwcy nlgwcy commented Sep 30, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Sep 30, 2024
@nlgwcy
fix slow restart in workload mode
390e845 
Signed-off-by: wuchangye <wuchangye@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.12%. Comparing base (764f121) to head (390e845).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/bpf/bpf.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/bpf/bpf_kmesh_l4_workload.go 40.69% <100.00%> (ø)
pkg/bpf/bpf.go 43.60% <0.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9634e1...390e845. Read the comment docs.

@nlgwcy
Copy link
Copy Markdown
Contributor Author

nlgwcy commented Sep 30, 2024

/retest

hzxuzhonghu
hzxuzhonghu approved these changes Sep 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Sep 30, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit bff5b9a into kmesh-net:main Sep 30, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Sep 30, 2024

In response to a cherrypick label: new pull request created: #926

@kmesh-bot kmesh-bot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@bitcoffeeiux bitcoffeeiux Awaiting requested review from bitcoffeeiux

@YaoZengzeng YaoZengzeng Awaiting requested review from YaoZengzeng

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved cherrypick/release-0.5 kind/bug Something isn't working lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nlgwcy @kmesh-bot @hzxuzhonghu