Skip to content

rm depends/include/bpf_helper_defs_ext.h#916

Merged
kmesh-bot merged 3 commits intokmesh-net:mainfrom
hzxuzhonghu:headerfile-license
Oct 12, 2024
Merged

rm depends/include/bpf_helper_defs_ext.h#916
kmesh-bot merged 3 commits intokmesh-net:mainfrom
hzxuzhonghu:headerfile-license

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu commented Sep 30, 2024 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

bpf/include/bpf_helper_defs_ext.h is generated from this depends/include/bpf_helper_defs_ext.h

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

LiZhenCheng9527 commented Sep 30, 2024

/lgtm

@hzxuzhonghu hzxuzhonghu changed the title update license rm depends/include/bpf_helper_defs_ext.h Sep 30, 2024
hzxuzhonghu
hzxuzhonghu commented Sep 30, 2024
View reviewed changes
@kmesh-bot kmesh-bot added size/S and removed size/M labels Oct 8, 2024
@hzxuzhonghu
Copy link
Copy Markdown
Member Author

hzxuzhonghu commented Oct 8, 2024 •
edited
Loading

/retest

Weird， this test failed

=== NAME  TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation
    manage_controller_test.go:186: 
        	Error Trace:	/home/runner/work/kmesh/kmesh/pkg/controller/manage/manage_controller_test.go:186
        	            				/home/runner/work/kmesh/kmesh/pkg/controller/manage/manage_controller_test.go:425
        	Error:      	Not equal: 
        	            	expected: false
        	            	actual  : true
        	Test:       	TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation
        	Messages:   	unexpected value for disabled flag

@Okabe-Rintarou-0

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.91%. Comparing base (ef71fe9) to head (0a7735d).
Report is 38 commits behind head on main.

see 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c383a...0a7735d. Read the comment docs.

@hzxuzhonghu
update license
0c5df25 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
rm depends/include/bpf_helper_defs_ext.h
45a7064 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
Update
0a7735d 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
Copy link
Copy Markdown
Member Author

hzxuzhonghu commented Oct 10, 2024

/assign @lec-bit

@nlgwcy
Copy link
Copy Markdown
Contributor

nlgwcy commented Oct 12, 2024

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Oct 12, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit b85ca41 into kmesh-net:main Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitcoffeeiux bitcoffeeiux Awaiting requested review from bitcoffeeiux

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@nlgwcy nlgwcy

@lec-bit lec-bit

@LiZhenCheng9527 LiZhenCheng9527

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hzxuzhonghu @LiZhenCheng9527 @nlgwcy @kmesh-bot @lec-bit