Skip to content

Update kmesh_deploy_and_develop_in_kind.md#904

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
derekwin:doc-log-update
Sep 29, 2024
Merged

Update kmesh_deploy_and_develop_in_kind.md#904
kmesh-bot merged 1 commit intokmesh-net:mainfrom
derekwin:doc-log-update

Conversation

@derekwin
Copy link
Copy Markdown
Contributor

@derekwin derekwin commented Sep 26, 2024

What type of PR is this?

/kind documentation

./kmeshctl log $kmesh_pod_name --set default:debug
```

`make build` will generate kmeshctl in the kmesh directory.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After v0.5.0 release, kmeshctl will be included in the release tarball, and we could use it directly without compiling it on site.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed it.


```shell
kubectl exec -it $kmesh_pod_name -n kmesh-system -- kmesh-daemon log --set default:debug
./kmeshctl log $kmesh_pod_name --set default:debug
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
./kmeshctl log $kmesh_pod_name --set default:debug
kmeshctl log $kmesh_pod_name --set default:debug

Specially, for bpf logs:
```shell
kubectl exec -it $kmesh_pod_name -n kmesh-system -- kmesh-daemon log --set bpf:debug
./kmeshctl log $kmesh_pod_name --set bpf:debug
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

./kmeshctl log $kmesh_pod_name --set default:debug
```

Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove white spaces

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@YaoZengzeng
Copy link
Copy Markdown
Member

@derekwin you should sign-off your every commits to pass DCO.

Signed-off-by: derekwin <jacelau@outlook.com>
@derekwin
Copy link
Copy Markdown
Contributor Author

@derekwin you should sign-off your every commits to pass DCO.

ok

@YaoZengzeng
Copy link
Copy Markdown
Member

/lgtm

@YaoZengzeng
Copy link
Copy Markdown
Member

/approve

@kmesh-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: YaoZengzeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit ce658aa into kmesh-net:main Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants