Conversation
ctl/waypoint/waypoint.go
Outdated
| KmeshWaypointForTrafficTypeLabel = "istio.io/waypoint-for" | ||
|
|
||
| WaypointImageAnnotation = "sidecar.istio.io/proxyImage" | ||
| KmeshWaypointImage = "ghcr.io/kmesh-net/waypoint:latest" |
There was a problem hiding this comment.
nit：If it in 0.5.0 release, is waypoint version also fixed to 0.5.0?
There was a problem hiding this comment.
Good catch!
It should be the same as the release version, but it should also be configurable, because we prefer to use the latest image during dev.
cda58ed to
0eebb5e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
26cc101 to
9d4b068
Compare
kmeshctl waypoint frameworkkmeshctl waypoint framework
| }, | ||
| } | ||
| waypointGenerateCmd.Flags().StringVar(&trafficType, | ||
| "for", |
There was a problem hiding this comment.
There is no example for this usage
|
|
||
| ver := version.Get().GitVersion | ||
|
|
||
| return fmt.Sprintf("ghcr.io/kmesh-net/waypoint:v%s", ver) |
There was a problem hiding this comment.
ghcr.io/kmesh-net/waypoint can be customized
There was a problem hiding this comment.
You could use --image flag to customize waypoint image.
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
|
@hzxuzhonghu updated |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Implement
kmeshctl waypointsubcommand, so we could use it to better manage waypoints.Which issue(s) this PR fixes:
Fixes part of #821
Special notes for your reviewer:
Does this PR introduce a user-facing change?: