Skip to content

Fix build warning and remove docker pull explicitly#893

Merged
nlgwcy merged 1 commit intokmesh-net:mainfrom
hzxuzhonghu:mis-fix
Sep 25, 2024
Merged

Fix build warning and remove docker pull explicitly#893
nlgwcy merged 1 commit intokmesh-net:mainfrom
hzxuzhonghu:mis-fix

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu commented Sep 25, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hzxuzhonghu
Fix build warning and remove docker pull explicitly
20cb06f 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
Copy link
Copy Markdown
Member Author

hzxuzhonghu commented Sep 25, 2024

/cherry-pick release-0.5

@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Sep 25, 2024

@hzxuzhonghu: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.98%. Comparing base (e816990) to head (20cb06f).
Report is 18 commits behind head on main.

see 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411615c...20cb06f. Read the comment docs.

@kwb0523
Copy link
Copy Markdown
Contributor

kwb0523 commented Sep 25, 2024

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Sep 25, 2024
@nlgwcy
Copy link
Copy Markdown
Contributor

nlgwcy commented Sep 25, 2024

/lgtm
/approve

@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlgwcy nlgwcy enabled auto-merge September 25, 2024 09:17
@nlgwcy nlgwcy disabled auto-merge September 25, 2024 09:17
@nlgwcy nlgwcy merged commit 20cb2d8 into kmesh-net:main Sep 25, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Sep 25, 2024

In response to a cherrypick label: new pull request created: #897

@kmesh-bot kmesh-bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitcoffeeiux bitcoffeeiux Awaiting requested review from bitcoffeeiux

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@kwb0523 kwb0523

@nlgwcy nlgwcy

Labels

approved cherrypick/release-0.5 lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hzxuzhonghu @kmesh-bot @kwb0523 @nlgwcy