Merged
Conversation
|
|
||
| if err := sc.Load(); err != nil { | ||
| if errors.As(err, &ve) { | ||
| return fmt.Errorf("bpf load failed: %+v", ve) |
Contributor
There was a problem hiding this comment.
Is this action to give a more accurate error message?
Member
Author
There was a problem hiding this comment.
I think so, this is recently added by @weli-l otherwise the error info is truncated
pkg/bpf/ads/loader_enhanced.go
Outdated
| } | ||
|
|
||
| func NewBpfKmesh(cfg *options.BpfConfig) (*BpfAds, error) { | ||
| var err error |
pkg/bpf/ads/loader_enhanced.go
Outdated
| } | ||
|
|
||
| func (sc *BpfAds) Load() error { | ||
| var err error |
pkg/bpf/ads/loader_enhanced.go
Outdated
| } | ||
|
|
||
| func (sc *BpfAds) Attach() error { | ||
| var err error |
Member
Author
|
/assign @lec-bit |
4de8feb to
6ce9bca
Compare
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
9b3bf5f to
d8cd4b0
Compare
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Member
Author
|
cc @nlgwcy |
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
make the bpf loader more readable and deduplicate error handling
Which issue(s) this PR fixes:
Fixes #858
Special notes for your reviewer:
Does this PR introduce a user-facing change?: