e2e test to include bookinfo as test application#790
e2e test to include bookinfo as test application#790kmesh-bot merged 2 commits intokmesh-net:mainfrom
Conversation
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
/retest |
| t.Fatalf("failed to install bookinfo: %v", err) | ||
| } | ||
| t.Cleanup(func() { | ||
| if _, err := shell.Execute(true, fmt.Sprintf("kubectl delete -f https://raw.githubusercontent.com/istio/istio/release-1.22/samples/bookinfo/platform/kube/bookinfo.yaml -n %s", namespace)); err != nil { |
There was a problem hiding this comment.
Does this need to change with istio version changes
There was a problem hiding this comment.
Does this need to change with istio version changes
It should not be needed at present. We only use very basic functions here and bookinfo itself will not change much with upgrade of istio.
test/e2e/baseline_test.go
Outdated
| }) | ||
|
|
||
| // Install sleep as client. | ||
| if _, err := shell.Execute(true, fmt.Sprintf("kubectl apply -f https://raw.githubusercontent.com/istio/istio/release-1.21/samples/sleep/sleep.yaml -n %s", namespace)); err != nil { |
There was a problem hiding this comment.
Why is it release 1.22 above and release 1.21 here?
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
|
/lgtm |
hzxuzhonghu
left a comment
There was a problem hiding this comment.
This is very hack, we can use call options provided by istio
But i wish this test to cover ipv4 mapped v6 asap, so
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #766
Special notes for your reviewer:
Does this PR introduce a user-facing change?: