Fix argument list too long in manage controller#711
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Continue to review full report in Codecov by Sentry.
|
hzxuzhonghu
left a comment
There was a problem hiding this comment.
An alternatrive maybe make these functions as a method of KmeshManageController, tehn you donot need to pass these args
This seems to be more reasonable, please make a review @hzxuzhonghu |
| queue.AddRateLimited(QueueItem{podName: pod.Name, podNs: pod.Namespace, action: ActionAddAnnotation}) | ||
| _ = linkXdp(nspath, xdpProgFd, mode) | ||
| kmc.queue.AddRateLimited(QueueItem{podName: pod.Name, podNs: pod.Namespace, action: ActionAddAnnotation}) | ||
| _ = linkXdp(nspath, kmc.xdpProgFd, kmc.mode) |
There was a problem hiding this comment.
why handle this error？
There was a problem hiding this comment.
You mean why NOT handle this error? Because error is handled in linkXdp
Signed-off-by: talon <tianmuyang@huawei.com>
|
@hzxuzhonghu Please review |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix argument list too long in manage controller in #679
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: