Skip to content

[cherry-pick 0.4] add service metrics#710

Merged
kmesh-bot merged 14 commits intokmesh-net:release-0.4from
LiZhenCheng9527:cherry-0.4
Aug 12, 2024
Merged

[cherry-pick 0.4] add service metrics#710
kmesh-bot merged 14 commits intokmesh-net:release-0.4from
LiZhenCheng9527:cherry-0.4

Conversation

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #701

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


nlgwcy and others added 14 commits August 9, 2024 10:25
Signed-off-by: wuchangye <wuchangye@huawei.com>
Signed-off-by: wuchangye <wuchangye@huawei.com>
Signed-off-by: wuchangye <wuchangye@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@hzxuzhonghu
Copy link
Copy Markdown
Member

is the workload nil check included?

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor Author

is the workload nil check included?

included

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor Author

/cc @hzxuzhonghu

@kmesh-bot kmesh-bot requested a review from hzxuzhonghu August 12, 2024 02:19
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit bc72de3 into kmesh-net:release-0.4 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants