Skip to content

fix waypoint's processing of TCP#681

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
YaoZengzeng:tcp
Aug 12, 2024
Merged

fix waypoint's processing of TCP#681
kmesh-bot merged 2 commits intokmesh-net:mainfrom
YaoZengzeng:tcp

Conversation

@YaoZengzeng
Copy link
Copy Markdown
Member

@YaoZengzeng YaoZengzeng commented Aug 5, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

fixes the failuire in waypoint processing non-HTTP tcp traffic.

Which issue(s) this PR fixes:
Fixes #667

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Aug 5, 2024
@YaoZengzeng YaoZengzeng force-pushed the tcp branch 2 times, most recently from 6fb16c9 to 018fa04 Compare August 5, 2024 08:58
@YaoZengzeng
fix waypoint's processing of TCP
568a5dd 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@YaoZengzeng
make waypoint image truly configurable
d75429a 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.24%. Comparing base (433592b) to head (d75429a).
Report is 3 commits behind head on main.

see 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda7049...d75429a. Read the comment docs.

hzxuzhonghu
hzxuzhonghu approved these changes Aug 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Can we add more protocol tests

@kmesh-bot kmesh-bot added the lgtm label Aug 12, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YaoZengzeng
Copy link
Copy Markdown
Member Author

YaoZengzeng commented Aug 12, 2024

/retest

@kmesh-bot kmesh-bot merged commit 864ec6f into kmesh-net:main Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved kind/bug Something isn't working lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Access tcp service through waypoint got unexpected HTTP/1.1 400 Bad Request

3 participants

@YaoZengzeng @kmesh-bot @hzxuzhonghu