Skip to content

Short circuit when svc endpoint count = 0#675

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
hzxuzhonghu:ep-cnt
Aug 5, 2024
Merged

Short circuit when svc endpoint count = 0#675
kmesh-bot merged 1 commit intokmesh-net:mainfrom
hzxuzhonghu:ep-cnt

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu commented Aug 2, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.87%. Comparing base (68d7f31) to head (a0a01c1).
Report is 34 commits behind head on main.

see 10 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a7312...a0a01c1. Read the comment docs.

@hzxuzhonghu
Check endpoint == 0, and short circuit
a0a01c1 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@supercharge-xsy
Copy link
Copy Markdown
Contributor

supercharge-xsy commented Aug 5, 2024

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Aug 5, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supercharge-xsy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 7bbbbbb into kmesh-net:main Aug 5, 2024
@hzxuzhonghu
Copy link
Copy Markdown
Member Author

hzxuzhonghu commented Aug 5, 2024

/label cherrypick/release-0.4

@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Aug 5, 2024

@hzxuzhonghu: The label(s) /label cherrypick/release-0.4 cannot be applied. These labels are supported: tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label cherrypick/release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kmesh-bot kmesh-bot mentioned this pull request Aug 5, 2024
Merged
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Aug 5, 2024

In response to a cherrypick label: new pull request created: #685

@hzxuzhonghu hzxuzhonghu deleted the ep-cnt branch August 30, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@supercharge-xsy supercharge-xsy

Labels

approved cherrypick/release-0.4 lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hzxuzhonghu @supercharge-xsy @kmesh-bot