Skip to content

Enable cleanup in e2e#649

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
noobwei:main
Jul 30, 2024
Merged

Enable cleanup in e2e#649
kmesh-bot merged 1 commit intokmesh-net:mainfrom
noobwei:main

Conversation

@noobwei
Copy link
Copy Markdown
Contributor

@noobwei noobwei commented Jul 29, 2024

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Enable cleanup in E2E, include cleanup the kind cluster or docker registry or both

Which issue(s) this PR fixes:
Fixes #522

Special notes for your reviewer:

The previous PR was closed because of a bad git action.

Does this PR introduce a user-facing change?:

@noobwei
Enable cleanup in e2e
4f55115 
Signed-off-by: noobwei <ta22230@bristol.ac.uk>
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Jul 29, 2024
@hzxuzhonghu
Copy link
Copy Markdown
Member

hzxuzhonghu commented Jul 30, 2024

Weird TestPodSidecarLabelChangeTriggersAddIptablesAction still flake @Okabe-Rintarou-0

hzxuzhonghu
hzxuzhonghu approved these changes Jul 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Jul 30, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 354bba4 into kmesh-net:main Jul 30, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.91%. Comparing base (4a7807b) to head (4f55115).
Report is 20 commits behind head on main.

see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8b1b0...4f55115. Read the comment docs.

@YaoZengzeng YaoZengzeng mentioned this pull request Jul 31, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved kind/enhancement New feature or request lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[E2E Enchancement] define command line flags for different cleanup granularity

3 participants

@noobwei @hzxuzhonghu @kmesh-bot