Skip to content

enable select some e2e cases to run or skip some cases#638

Merged
kmesh-bot merged 3 commits intokmesh-net:mainfrom
YaoZengzeng:run-tests
Jul 26, 2024
Merged

enable select some e2e cases to run or skip some cases#638
kmesh-bot merged 3 commits intokmesh-net:mainfrom
YaoZengzeng:run-tests

Conversation

@YaoZengzeng
Copy link
Copy Markdown
Member

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Add two flags to E2E framework:

--select-cases: select some cases to run
--skip-cases: skip some cases and run others

Which issue(s) this PR fixes:
Fixes #523

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Jul 25, 2024
@kmesh-bot kmesh-bot requested review from bitcoffeeiux and nlgwcy July 25, 2024 12:47
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.78%. Comparing base (f5f92ac) to head (4a7807b).
Report is 40 commits behind head on main.

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c2e03...4a7807b. Read the comment docs.

go test -v -tags=integ $ROOT_DIR/test/e2e/... -count=1
cmd="go test -v -tags=integ $ROOT_DIR/test/e2e/... -count=1 $PARAMS"

eval $cmd
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no need to use eval and -count=1 can be removed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"-count=1" is to disable go test cache. Enabling it by default is more convenient for local debugging and developing of e2e test cases. For CI, since it runs from scratch and only run once, it has no effect.

Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Copy Markdown
Member

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Jul 26, 2024
@kmesh-bot kmesh-bot merged commit cd60b90 into kmesh-net:main Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[E2E Enchancement] select a subset of test cases to run

3 participants