Skip to content

preclude pod with host network to be managed by kmesh#634

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
hzxuzhonghu:exclude-hostnetwork
Jul 28, 2024
Merged

preclude pod with host network to be managed by kmesh#634
kmesh-bot merged 1 commit intokmesh-net:mainfrom
hzxuzhonghu:exclude-hostnetwork

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu commented Jul 25, 2024

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #630

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hzxuzhonghu
preclude pod with host network to be managed by kmesh
2703043 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Jul 25, 2024
@kmesh-bot kmesh-bot requested review from bitcoffeeiux and nlgwcy July 25, 2024 06:43
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.29%. Comparing base (f5f92ac) to head (2703043).
Report is 48 commits behind head on main.

Files Coverage Δ
pkg/utils/enroll.go 94.11% <100.00%> (ø)

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c2e03...2703043. Read the comment docs.

@nlgwcy
Copy link
Copy Markdown
Contributor

nlgwcy commented Jul 28, 2024

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Jul 28, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Jul 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit a068913 into kmesh-net:main Jul 28, 2024
@hzxuzhonghu hzxuzhonghu deleted the exclude-hostnetwork branch July 29, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitcoffeeiux bitcoffeeiux Awaiting requested review from bitcoffeeiux

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

Assignees

@nlgwcy nlgwcy

Labels

approved kind/enhancement New feature or request lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should exclude managing pods using hostnetwork

3 participants

@hzxuzhonghu @nlgwcy @kmesh-bot